Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: disable witness related schedulers by default #7765

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 25, 2024

What problem does this PR solve?

Issue Number: close #8891.

What is changed and how does it work?

Since it's not GA, I prefer to disable it by default.

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jan 25, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 January 25, 2024 10:05
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2024
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2024
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #7765 (6119f44) into master (0d10882) will decrease coverage by 0.29%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6119f44 differs from pull request most recent head faa4b07. Consider uploading reports for the commit faa4b07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7765      +/-   ##
==========================================
- Coverage   69.99%   69.71%   -0.29%     
==========================================
  Files         430      430              
  Lines       47632    47632              
==========================================
- Hits        33340    33205     -135     
- Misses      11540    11670     +130     
- Partials     2752     2757       +5     
Flag Coverage Δ
unittests 69.71% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented Jan 26, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6119f44

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 26, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 5b939c6 into tikv:master Jan 26, 2024
22 checks passed
@rleungx rleungx deleted the disable-witness-scheduler branch January 29, 2024 02:40
@rleungx rleungx added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8892.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8893.

ti-chi-bot bot added a commit that referenced this pull request Dec 12, 2024
close #8891

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Witness related schedulers should not be in default schedulers
5 participants