Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way to get fetch args in sparo fetch & cr fix #14

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

EscapeB
Copy link
Member

@EscapeB EscapeB commented Feb 22, 2024

Basic Checks

Have you run rush change for this change?

  • Yes
  • No

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Summary

  1. Add remote and branch arguments in sparo fetch
  2. CR fix for feat: sync changes #2

Detail

  1. Add getBranchRemote function in gitService to get current branch remote.
  2. Change the way to get fetch args
    • If user defined remote and branch, use users' input.
    • If not user not defined remote and branch, use getBranchRemote to get remote and use current branch.

@EscapeB EscapeB changed the title fix: cr fix Change the way to get fetch args in sparo fetch & cr fix Feb 22, 2024
@EscapeB EscapeB merged commit 325e168 into tiktok:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants