Imx9 bug fixes 2511 #318
Merged
Imx9 bug fixes 2511 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid spurious interrupts on reboot Signed-off-by: Jouni Ukkonen <[email protected]>
jlaitine
approved these changes
Nov 26, 2024
|
|
||
| up_invalidate_dcache((uintptr_t)buffer, | ||
| (uintptr_t)buffer + ALIGN_UP(nbytes)); | ||
| int n = nbytes; | ||
|
|
There was a problem hiding this comment.
This is fine, but what is the cache invalidate above about???
| while (n-- > 0) | ||
| { | ||
| *buffer++ = *src++; | ||
| } |
There was a problem hiding this comment.
Again, the cache clean below? Should we remove those at the same if they are useless?
libc memcpy cannot access fspi memory space correctly remove unnecessary debugassert and cache operations Signed-off-by: Jouni Ukkonen <[email protected]>
joukkone
force-pushed
the
imx9_bug_fixes_2511
branch
from
ba26fee to
0ac2cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing