forked from apache/nuttx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrapper to support multiple sdio device drivers #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnippula
force-pushed
the
sdio-dev
branch
4 times, most recently
from
January 29, 2024 13:45
6edcef0
to
badfdad
Compare
jnippula
changed the title
wrapper to sdio device drivers
wrapper to support multiple sdio device drivers
Jan 29, 2024
eenurkka
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
pussuw
reviewed
Jan 30, 2024
pussuw
reviewed
Jan 30, 2024
pussuw
reviewed
Jan 30, 2024
Looks like this is a good candidate for upstreaming, could you do that ? |
jnippula
force-pushed
the
sdio-dev
branch
2 times, most recently
from
January 30, 2024 11:18
b6dcb2d
to
acfd77b
Compare
pussuw
reviewed
Jan 30, 2024
pussuw
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdio device wrapper to support both mpfs_emmcsd and mpfs_coremmc drivers simultaneously