Skip to content

Commit

Permalink
[metric] GoogleContainerTools#2 Cleanup declared_resources metric name
Browse files Browse the repository at this point in the history
The metric name was changed to `declared_resources_total` using the metricstransform processor without communicating in the documentation / release note and the intention was unclear.

This change reverts the name change and adds e2e test around all the [available metrics](http://cloud/kubernetes-engine/enterprise/config-sync/docs/how-to/monitoring-config-sync) in GCM. The check skips the counter metrics for now as they have no data when no error condition has happened.
  • Loading branch information
tiffanny29631 committed Jun 3, 2024
1 parent 1c018a0 commit 83b1a23
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion pkg/metrics/otel.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ processors:
aggregation_type: max
- include: declared_resources
action: update
new_name: current_declared_resources
operations:
- action: aggregate_labels
label_set: []
Expand Down
2 changes: 1 addition & 1 deletion pkg/reconcilermanager/controllers/otel_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (
// otel-collector ConfigMap.
// See `CollectorConfigGooglecloud` in `pkg/metrics/otel.go`
// Used by TestOtelReconcilerGooglecloud.
depAnnotationGooglecloud = "c2f6078a9afe1f32721173e9e15bbab5"
depAnnotationGooglecloud = "9ede45bd37596a48556f6dbba3e9fdb3"
// depAnnotationGooglecloud is the expected hash of the custom
// otel-collector ConfigMap test artifact.
// Used by TestOtelReconcilerCustom.
Expand Down

0 comments on commit 83b1a23

Please sign in to comment.