refactor(hesai_hw_interface): case style fixes

[mojomex]

PR Type

• Improvement

Related Links

• chore: fix case styles #205 - Hesai HW interface was left out due to other in-flight PRs that would have been a pain to merge at the time

Description

Fix the case style of all symbols in the Hesai hardware interface. This marks the completion of the work started in #205.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 206 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (3d42cd0) to head (cc8d563).

Files with missing lines	Patch %	Lines
.../nebula_hesai_hw_interfaces/hesai_hw_interface.cpp	0.00%	186 Missing ⚠️
nebula_ros/src/hesai/hw_interface_wrapper.cpp	0.00%	8 Missing ⚠️
nebula_ros/src/hesai/hw_monitor_wrapper.cpp	0.00%	7 Missing ⚠️
nebula_ros/src/hesai/hesai_ros_wrapper.cpp	0.00%	5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3d42cd0) and HEAD (cc8d563). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (3d42cd0)	HEAD (cc8d563)
total	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #238       +/-   ##
==========================================
- Coverage   26.11%   0.00%   -26.12%     
==========================================
  Files         101      88       -13     
  Lines        9212    7941     -1271     
  Branches     2211     938     -1273     
==========================================
- Hits         2406       0     -2406     
- Misses       6417    7941     +1524     
+ Partials      389       0      -389     

Flag	Coverage Δ
differential	0.00% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knzo25]

In some of my code I am using lots of these as well and was wondering which guidelines did you follow for the g_ prefix. Additionally, would constexpr be better here?

[mojomex]

This one is (regrettably) part of Autoware's .clang-tidy configuration, which we based ours on:
https://github.com/autowarefoundation/autoware/blob/0e44b14187196ab0fd75a69bf0eee27b086d3b47/.clang-tidy#L447-L448

Also not a fan but I think it's best to keep the projects mostly in sync.