Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(velodyne): generic decoder #228

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

refactor(velodyne): generic decoder #228

wants to merge 44 commits into from

Commits on Nov 18, 2024

  1. save progress (velodyne_generic_decoder.cpp logic done except unpack())

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6dc9df5 View commit details
    Browse the repository at this point in the history

  2. push combined vlp16/vls128 decoder for testing

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    350402a View commit details
    Browse the repository at this point in the history

  3. update templating and fix various bugs

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4aebd60 View commit details
    Browse the repository at this point in the history

  4. passes tests VLP16/VLS128 combined decoder

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a59312e View commit details
    Browse the repository at this point in the history

  5. remove generic decoder cpp file

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4f44e92 View commit details
    Browse the repository at this point in the history

  6. clean up files

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3807a47 View commit details
    Browse the repository at this point in the history

  7. better develop velodyne sensor classes

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c1e1d44 View commit details
    Browse the repository at this point in the history

  8. push VLP32 results *almost* identical to original decoder

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    cc30a23 View commit details
    Browse the repository at this point in the history

  9. change floats to doubles

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6958a35 View commit details
    Browse the repository at this point in the history

  10. return to calculating ROI points based on corrected azimuth

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8977485 View commit details
    Browse the repository at this point in the history

  11. adjust VLP32 laser azimuth cache calculation and add note

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    83dd97d View commit details
    Browse the repository at this point in the history

  12. fix timing offsets calculation

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c492e58 View commit details
    Browse the repository at this point in the history

  13. update TODOs

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7f9817b View commit details
    Browse the repository at this point in the history

  14. fix get_pointcloud() (breaks vlp16 test)

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    89819e5 View commit details
    Browse the repository at this point in the history

  15. remove now unnecessary vlp32 decoder

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    031012a View commit details
    Browse the repository at this point in the history

  16. fix compiler warnings

    @bgilby59 @mojomex
    bgilby59 authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    25ebe2a View commit details
    Browse the repository at this point in the history

  17. delete empty files

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1902948 View commit details
    Browse the repository at this point in the history

  18. fix double into float for test

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    9f7b0b2 View commit details
    Browse the repository at this point in the history

  19. fix pointcloud number difference in test

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    446bdc8 View commit details
    Browse the repository at this point in the history

  20. fix phase_diff for test

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    02e5dc3 View commit details
    Browse the repository at this point in the history

  21. pass 32 test

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c87706c View commit details
    Browse the repository at this point in the history

  22. fix spell miss in comment out

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d8ade25 View commit details
    Browse the repository at this point in the history

  23. add @brief and explain comments

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    afc178a View commit details
    Browse the repository at this point in the history

  24. fix typo in comment

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    00eb01d View commit details
    Browse the repository at this point in the history

  25. fix typo in comments

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    273485f View commit details
    Browse the repository at this point in the history

  26. fix typo in comment

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a98c546 View commit details
    Browse the repository at this point in the history

  27. create const pointsPerPacket

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2626ec6 View commit details
    Browse the repository at this point in the history

  28. fix i-statement

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7266e98 View commit details
    Browse the repository at this point in the history

  29. fix if_statement

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    75d2028 View commit details
    Browse the repository at this point in the history

  30. add error handling

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e653c65 View commit details
    Browse the repository at this point in the history

  31. fix long into int

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b8aaf1c View commit details
    Browse the repository at this point in the history

  32. move all sensor-specific constants to the respective sensor's file

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ef72a54 View commit details
    Browse the repository at this point in the history

  33. Use memcpy

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b64ef71 View commit details
    Browse the repository at this point in the history

  34. create elodyne_packet.hpp

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    fa05683 View commit details
    Browse the repository at this point in the history

  35. add comment and take error

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    247bcec View commit details
    Browse the repository at this point in the history

  36. delete submodule

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    33683ca View commit details
    Browse the repository at this point in the history

  37. fix @belief comment

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    03be3c6 View commit details
    Browse the repository at this point in the history

  38. fix raw_block

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0305f7c View commit details
    Browse the repository at this point in the history

  39. add getBank function

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    64fc8f6 View commit details
    Browse the repository at this point in the history

  40. delete include

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ab294c6 View commit details
    Browse the repository at this point in the history

  41. add unit_idx

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0b4ba3a View commit details
    Browse the repository at this point in the history

  42. del const

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    618f321 View commit details
    Browse the repository at this point in the history

  43. arrange code

    @ike-kazu @mojomex
    ike-kazu authored and mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    20a1e22 View commit details
    Browse the repository at this point in the history

  44. chore(velodyne): fix compiler and clang-tidy errors after rebase 

    Signed-off-by: Max SCHMELLER <[email protected]>
    @mojomex
    mojomex committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    1696281 View commit details
    Browse the repository at this point in the history