Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expected.hpp): add missing string include #152

Merged
merged 1 commit into from
May 21, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented May 21, 2024

PR Type

  • Bug Fix

Description

Added #include <string> which was missing from the header

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz May 21, 2024 10:24
@mojomex mojomex self-assigned this May 21, 2024
@mojomex mojomex changed the base branch from main to develop May 21, 2024 10:29
@mojomex mojomex removed the request for review from drwnz May 21, 2024 10:29
@mojomex mojomex merged commit 2ec268f into tier4:develop May 21, 2024
6 checks passed
@mojomex mojomex deleted the expected-include-fix branch May 21, 2024 10:31
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants