Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nebula_msgs): fix dependencies #145

Merged
merged 1 commit into from
May 8, 2024
Merged

build(nebula_msgs): fix dependencies #145

merged 1 commit into from
May 8, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented May 8, 2024

PR Type

  • Bug Fix

Related Links

https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/8892602199/job/24417095611?pr=85

Description

This PR adds a build dependency for ament_cmake_auto, it's being used in CMakeLists.txt but not declared in package.xml

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@esteve
Copy link
Contributor Author

esteve commented May 8, 2024

@knzo25 I can't assign this PR, but I've noticed you're the maintainer for this package. Could you have a look at this change when you have a moment? Thanks.

Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry, this is the same error you told us before but I did not notice it was also here 🙇

@knzo25 knzo25 merged commit be26ceb into tier4:main May 8, 2024
6 checks passed
@esteve esteve deleted the patch-1 branch May 8, 2024 14:29
@esteve
Copy link
Contributor Author

esteve commented May 8, 2024

@knzo25 no problem 🙂 Thanks for reviewing this change so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants