Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(velodyne): add test for vlp32 #141

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

bgilby59
Copy link
Contributor

@bgilby59 bgilby59 commented Apr 24, 2024

PR Type

  • New Feature

Related Links

Description

This PR adds a test for VLP32 that passes with the current VLP32 driver.

Review Procedure

  1. colcon test --event-handlers console_cohesion+ --packages-above nebula_common
  2. code review

Remarks

I confirmed the test is not trivial by arbitrarily changing the VLP32 driver and confirming the test fails.

A future PR should combine the VLP16, VLP32, and VLS128 tests into one generic Velodyne test as very few lines of code differ between the 3 tests.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@bgilby59 bgilby59 requested a review from mojomex April 24, 2024 07:00
@bgilby59 bgilby59 changed the title add test for vlp32 that passes with current driver feat(velodyne): add test for vlp32 Apr 24, 2024
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Tested:

  • Compiling Nebula and running tests (all pass ✔️)
  • Introducing a small offset to the decoded x coordinates in vlp32_decoder.cpp and recompiling. Test fails ✔️

LGTM!

@mojomex mojomex merged commit affb619 into tier4:main Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants