Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet-walletconnect): make WalletConnect chainIds optional #400

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Dec 10, 2024

closes #399

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: b6ac2ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@reactive-dot/wallet-walletconnect Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tien
Copy link
Owner

tien commented Dec 10, 2024

Thanks @Tbaut, can you create a changelog by running yarn changeset add?

@Tbaut
Copy link
Contributor Author

Tbaut commented Dec 10, 2024

Sure, I just did it.

@tien tien changed the title fix(): Make WalletConnect chainIds optional fix(wallet-walletconnect): make WalletConnect chainIds optional Dec 10, 2024
Copy link
Owner

@tien tien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor nits.

@Tbaut Tbaut requested a review from tien December 10, 2024 21:36
@tien tien merged commit bef0909 into tien:main Dec 10, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WalletConnect requiredNamespaces optionnal (and so should be chainIds)
2 participants