refactor!: nest tx options (#387)

tien · Dec 7, 2024 · 8ca10b3 · 8ca10b3
1 parent 8550dd1
commit 8ca10b3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/green-mayflies-dance.md b/.changeset/green-mayflies-dance.md
@@ -0,0 +1,5 @@
+---
+"@reactive-dot/react": minor
+---
+
+BREAKING: nested tx options to avoid possible property clash.
diff --git a/packages/react/src/hooks/use-mutation.ts b/packages/react/src/hooks/use-mutation.ts
@@ -65,8 +65,9 @@ export function useMutation<
         (
           get,
           _set,
-          submitOptions?: TxOptions<ReturnType<TAction>> & {
+          submitOptions?: {
             signer?: PolkadotSigner;
+            txOptions?: TxOptions<ReturnType<TAction>>;
           },
         ) => {
           const signer =
@@ -87,7 +88,10 @@ export function useMutation<
               mutationEventSubject.next({ ...eventProps, value: pending });
 
               return transaction
-                .signSubmitAndWatch(signer, submitOptions ?? options?.txOptions)
+                .signSubmitAndWatch(
+                  signer,
+                  submitOptions?.txOptions ?? options?.txOptions,
+                )
                 .pipe(
                   tap((value) =>
                     mutationEventSubject.next({ ...eventProps, value }),