refactor(react): use type intersection instead of generic (#40)

tien · Jul 23, 2024 · 003679a · 003679a
1 parent 04c0583
commit 003679a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/packages/react/src/hooks/types.ts b/packages/react/src/hooks/types.ts
@@ -1,7 +1,6 @@
 import type { ChainId } from "@reactive-dot/core";
 
-// eslint-disable-next-line @typescript-eslint/ban-types
-export type ChainHookOptions<TChainId extends ChainId = ChainId, T = {}> = T & {
+export type ChainHookOptions<TChainId extends ChainId = ChainId> = {
   /**
    * Override default chain ID
    */

diff --git a/packages/react/src/hooks/use-mutation.ts b/packages/react/src/hooks/use-mutation.ts
@@ -43,19 +43,16 @@ export function useMutation<
   TChainId extends ChainId,
 >(
   action: TAction,
-  options?: ChainHookOptions<
-    TChainId,
-    {
-      /**
-       * Override default signer
-       */
-      signer?: PolkadotSigner;
-      /**
-       * Additional transaction options
-       */
-      txOptions?: TxOptions<ReturnType<TAction>>;
-    }
-  >,
+  options?: ChainHookOptions<TChainId> & {
+    /**
+     * Override default signer
+     */
+    signer?: PolkadotSigner;
+    /**
+     * Additional transaction options
+     */
+    txOptions?: TxOptions<ReturnType<TAction>>;
+  },
 ) {
   const chainId = useChainId(options);
   const mutationEventSubject = useContext(MutationEventSubjectContext);