Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #4271 and #5444, aiming to fix #4269.
Like before, it aims to provide the convenience of setting some scale parameters, without comitting to a full scale yet.
Unlike #5444, this PR is closer to Claus' approach in #4271.
This PR the
scale_params()
function that populates a newScalesList$params
field. When a new scale is added, it will get updated with the parameters in that field. The update mechanism required the most attention. Every<Scale>
class now has aScale$new()
method that takes on most of the work thatcontinuous_scale()
,discrete_scale()
,binned_scale()
constructors were doing before. TheScale$update()
method is a thin wrapper around this and should resolve gnarly situations (e.g. limit transformation).In the demo below we can note:
The update mechanism should also recognise invalid updates:
Created on 2024-11-22 with reprex v2.1.1