Fix bug in fallback of grid::linearGradient()
#6146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not fix an active issue. Instead it fixes a bug that should have been an issue, but isn't.
Briefly, when
linearGradient
is found in {grid}'s namespace, we want to declare that thelinearGradient()
function that ggplot2 uses is the one from {grid} and not the one we define here:ggplot2/R/backports.R
Lines 55 to 56 in ddd207e
However, we're assigning the result of
linearGradient()
, not the function itself. This PR rectifies this mistake.This doesn't really affect anybody as when we use
linearGradient()
as a function, the {grid} version is used anyway becauseggplot2::linearGradient
is not a function.