Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs for determining original predictor columns #215

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

topepo
Copy link
Member

@topepo topepo commented Jan 21, 2024

For external packages and upcoming feature selection APIs, we'll need a convenient way to determine the predictor column names in the data given to fit.workflow().

This is a standalone file with no dependencies.

The API names are not set in stone; we could use some suggestions on these.

@topepo topepo marked this pull request as ready for review January 22, 2024 03:15
@topepo topepo requested a review from simonpcouch January 22, 2024 03:15
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On board. :)

tests/testthat/test-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
R/standalone-input-names.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants