implement tune_args() and tunable()
#51
Conversation
|
|
| @@ -128,16 +128,15 @@ required_pkgs.equivocal_zone <- function(x, ...) { | |||
|
|
|||
| #' @export | |||
| tunable.equivocal_zone <- function(x, ...) { | |||
| tibble::new_tibble(list( | |||
There was a problem hiding this comment.
I have no arguments here, but I'm curious why you made that change. Is it for readability (since these aren't likely to be called a large number of times)?
There was a problem hiding this comment.
Thanks for calling that out. I'd like to revisit that and return to using new_tibble(), though there was a vector recycling issue that resulted in an interval vctrs error later on; I think we'll just need to do some manual rep()ping.
| ) | ||
| } | ||
|
|
||
| eval_call_info <- function(x) { |
There was a problem hiding this comment.
Should we make a small standalone file? If not, add some notes/link to original and noocv?
(same for other replicas below)
|
Going to go ahead and merge this to resolve package installation errors for the dev packages, spinning out new issues for Max's comments. See #52. |
Quite a bit of machinery borrowed from recipes. (Thanks, recipes!) Mostly generic to
tailorandadjustmentclasses, only adjustment-specific methods aretunable(), which were already implemented. :)Note that the dials functions referenced in the existing adjustment-specific
tunable()methods do not actually exist.