simplify concept of outcome type in the package #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13 and closes #11. This PR:
container(mode)
.type
argument ofadjust_*_calibration()
toadjust_*calibration(method)
.So, in the package,
"regression"
,"binary"
, or"multiclass"
.Notably, re: #13, this PR doesn't collapse
adjust_*_calibration()
into one function nor does it remove the option to define what is nowtype
ormethod
at specification time. I'm still intrigued at whether we could collapseadjust_*_calibration()
into one function, but there's enough complexity there that it ought to live in its own PR.