-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fit calibrators at fit.container()
#12
Conversation
# `adjust_*()` function via `arg_match0()`. | ||
# * `container_type`, the `type` argument either specified in `container()` | ||
# or inferred in `fit.container()`. | ||
check_type <- function(adjust_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple gaps in this logic depending on when/how different variants of the type
are supplied. Will sit tight on closing those up until we address #13.
@@ -1,8 +1,11 @@ | |||
#' Re-calibrate numeric predictions | |||
#' | |||
#' @param x A [container()]. | |||
#' @param calibrator A pre-trained calibration method from the \pkg{probably} | |||
#' package, such as [probably::cal_estimate_linear()]. | |||
#' @param type Character. One of `"linear"`, `"isotonic"`, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When putting together #13, ultimately felt that this should have a different argument than the same one supplied to container(type)
. I'd propose method
, but will wait to Replace All until there's more feedback here.
arg_nm = arg, | ||
error_call = call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one
Closes #9.
Before this PR, interface was:
Created on 2024-04-26 with reprex v2.1.0
With this PR:
Created on 2024-04-26 with reprex v2.1.0
Will be followed up by workflows PR updates (tidymodels/workflows#225) and a tune PR later today.