transition tests to reflect newest probably version

tidymodels/probably#158
tidymodels · Nov 12, 2024 · ef341cc · ef341cc
1 parent f83ab23
commit ef341cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/tests/testthat/test-adjust-numeric-calibration.R b/tests/testthat/test-adjust-numeric-calibration.R
@@ -47,14 +47,13 @@ test_that("adjust_numeric_calibration() respects `method` argument", {
       adjust_numeric_calibration(method = "isotonic")
   )
 
-  # TODO: cannot be `expect_no_condition()` due to tidymodels/probably#157
-  expect_no_error(expect_no_warning(
+  expect_no_condition(
     tlr_fit <- fit(tlr, d_calibration, outcome = y, estimate = y_pred)
-  ))
+  )
 
-  expect_no_error(expect_no_warning(
+  expect_no_condition(
     tlr_pred <- predict(tlr_fit, d_test)
-  ))
+  )
 
   # classes are as expected
   expect_s3_class(tlr, "tailor")

diff --git a/tests/testthat/test-adjust-probability-calibration.R b/tests/testthat/test-adjust-probability-calibration.R
@@ -61,19 +61,19 @@ test_that("basic adjust_probability_calibration() usage works", {
   )
 
   # TODO: cannot be `expect_no_condition()` due to tidymodels/probably#157
-  expect_no_error(expect_no_warning(
+  expect_no_condition(
     tlr_fit <- fit(
       tlr,
       d_calibration,
       outcome = c(truth),
       estimate = c(predicted),
       probabilities = c(Class1, Class2)
     )
-  ))
+  )
 
-  expect_no_error(expect_no_warning(
+  expect_no_condition(
     tlr_pred <- predict(tlr_fit, d_test)
-  ))
+  )
 
   # classes are as expected
   expect_s3_class(tlr, "tailor")