Check prop argument
#551
Merged
Check prop argument
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
commented
Sep 25, 2024
| check_prop <- function(prop, replace) { | ||
| acceptable_prop <- is.numeric(prop) | ||
| acceptable_prop <- acceptable_prop && | ||
| ((prop <= 1 && replace) || (prop < 1 && !replace)) |
There was a problem hiding this comment.
This distinction between what the upper boundary can be is removed because we are using it only in group_boot_splits():
Lines 264 to 265 in fe24aaa
We know where this particular
prop = 1 is coming from and that it's okay in this context so the new check_prop() can just check user input.
simonpcouch
approved these changes
Sep 25, 2024
| check_prop <- function(prop, replace) { | ||
| acceptable_prop <- is.numeric(prop) | ||
| acceptable_prop <- acceptable_prop && | ||
| ((prop <= 1 && replace) || (prop < 1 && !replace)) |
Co-authored-by: Simon P. Couch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #541 and #458
This PR reworks how the
propargument to various functions is checked.Several of the functions had a written-out check block in either the user-facing function or the underlying
*_split()function. The functions for grouped resampling were checkingpropdeep down the call chain with acheck_prop().I've decided to place the check in the user-facing functions and reworked it a little to benefit from the "friendly object type" in the standard checkers from rlang and only do the boundaries in a custom way.