Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual classes for inner_split() splits #497

Merged
merged 1 commit into from
May 24, 2024
Merged

Manual classes for inner_split() splits #497

merged 1 commit into from
May 24, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented May 24, 2024

Follow-up to #483 (comment)

what i meant, is that each paste0(class(x)[1], "_inner") in this file could be swapped with a mc_split_inner, apparent_split_inner, etc etc as they are called inside s3 methods, on the object that drives the s3 dispatch

@hfrick hfrick requested a review from EmilHvitfeldt May 24, 2024 16:19
@hfrick hfrick merged commit f228edf into main May 24, 2024
12 checks passed
@hfrick hfrick deleted the inner_split-explicit-classes branch May 24, 2024 16:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EmilHvitfeldt EmilHvitfeldt EmilHvitfeldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hfrick @EmilHvitfeldt