transition remaining rlang warnings and errors to cli #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on a corresponding extratests PR to update snapshots |
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Aug 28, 2024
EmilHvitfeldt
approved these changes
Aug 28, 2024
simonpcouch
commented
Aug 28, 2024
simonpcouch
commented
Aug 28, 2024
simonpcouch
commented
Aug 28, 2024
Co-authored-by: Emil Hvitfeldt <[email protected]>
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Aug 29, 2024
* testing and snapshot updates for tidymodels/parsnip#1162 * temp add remote for testing * update two other tests/snapshots * updated results * remove parsnip `Remotes` * a few more skips based on cran version failures * a few more skips based on cran version failures --------- Co-authored-by: simonpcouch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1081. (!!!)
Definitely many opportunities to write out some of these errors with rlang type checkers, but... one step at a time. :)
This will definitely cause some snap changes at least in extratests and likely in parsnip extensions. I say we update extratests snaps along with this PR but wait to make PRs to parsnip extensions until we've followed this PR up with another in parsnip that integrates rlang type checkers.