-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use {cli} for error messages #1081
Labels
tidy-dev-day 🤓
Tidyverse Developer Day rstd.io/tidy-dev-day
upkeep
maintenance, infrastructure, and similar
Comments
This was referenced Mar 28, 2024
Closed
This was referenced Jul 25, 2024
Closed
9/9 done! Huzzah! |
simonpcouch
added a commit
that referenced
this issue
Aug 28, 2024
I was a bit too eager in closing this—will reopen and later close with one last PR for the stray remaining ones. |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
tidy-dev-day 🤓
Tidyverse Developer Day rstd.io/tidy-dev-day
upkeep
maintenance, infrastructure, and similar
Most or all errors thrown in this package are made via
rlang::abort()
. We are transitioning tocli::cli_abort()
to make use of the richer styling options for errors via cli (which calls rlang under the hood).It is often sufficient to search for and replace the rlang version with the cli version together with adding a little bit of styling.
Some examples of the styling possibilities are in the general introduction under the section of Inline text formatting. More details on inline formatting and pluralization.
One aspect to watch out for when transitioning from
rlang::abort()
tocli::cli_abort()
are messages pre-assembled from user input as described here.#499 can serve as an example.
We are splitting this up into several batches:
R/aaa_models.R
#1136R/fit.R
#1137R/predict.R
#1138R/bart.R
,R/boost_tree.R
,R/decision_tree.R
, andR/gen_additive_mod.R
#1139R/glmnet-engines.R
,R/logistic_reg.R
,R/mars.R
, andR/mlp.R
#1140R/predict_class.R
,R/predict_classprob.R
,R/predict_numeric.R
, andR/predict_time.R
#1141R/nearest_neighbor_data.R
,R/rand_forest_data.R
,R/rand_forest.R
,R/svm_linear.R
, andR/svm_rbf_data.R
#1142The text was updated successfully, but these errors were encountered: