Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): commit fragments transaction only once after wrapping view being attached to a window #13263

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

drauggres
Copy link
Contributor

Prevent crash when using ti.map inside a ListView

fix TIMOB-28583
fix #13243

@build build added this to the 10.2.0 milestone Feb 8, 2022
@build build requested a review from a team February 8, 2022 12:55
@build
Copy link
Contributor

build commented Feb 8, 2022

Fails
🚫 Test reports missing for iPhone. This indicates that a build failed or the test app crashed
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 16341 tests are passing.
(There are 935 skipped tests not included in that total)

📖 🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍

Generated by 🚫 dangerJS against d2557ba

…iew being attached to a window

prevent crash when using ti.map inside a ListView

ref TIMOB-28583 fix tidev#13243
@hansemannn
Copy link
Collaborator

I can now finally confirm that this patch fixes all remaining issues related to map view crashes. Thank you so much!

Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine. Thank you @drauggres !

@hansemannn hansemannn merged commit 0838db2 into tidev:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: Random crash with map view in Ti.UI.ListSection footer
3 participants