feat: add support for node 22 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@ewanharris Looks good and works, but CI is failing. Would you kindly bump the Node.js verision for the the build and publish CI scripts to Node 18 and see if that helps? |
|
It looks like the issue is because of the python version which node-gyp fixed (nodejs/node-gyp/issues/2869), we need npm 10.2.2 or newer which 🤞🏻 should be in Node 18, if not I'll just add installing a new npm version |
ewanharris
force-pushed
the
chore/node-22
branch
from
ce31e0a
to
b3d5142
Compare
|
@cb1kenobi done and looks too be good! |
|
[email protected] published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-pre-gyp is still dead so update the patch we use to build and nan to bring in Node 22 compatibility, still outputs some deprecations but builds just fine. Tested locally and
.devicesworks as expected and is able to load the binding, have not tested anything further as I don't have the ability toCloses #87