Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce shiny pokemon to the whosthatpokemon app #2867

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vaquierm
Copy link

@vaquierm vaquierm commented Nov 7, 2024

Added the ability to randomly make the Pokemon shiny. (I am not the original creator of this app but thought it would be fun to add this!)

kyogreShiny.mov

A new parameter was added to allow the rate at which shiny Pokemon will randomly appear. By default, no shiny Pokemon will appear.

IMG_2577

A shiny animation was also added so that sparkles appear just like a shiny encounter in the Pokemon games. To make the animation of the stars smooth the root delay was divided by 5 from 125 to 25. All other frame calculations were adjusted to make the experience look the exact same except for the sparkles.

@tidbyt
Copy link

tidbyt bot commented Nov 7, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (N-Brooks) does not match the PR author (vaquierm)

@tidbyt-bot
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants