Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to provide function to find to find by other than id #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tjcouch-sil
Copy link

Added ability to provide a function to dockLayout.find instead of just an id. The function's first parameter is the box, panel, or tab being considered. The function returns true if the box/panel/tab matches and should be returned by the find function.

I called the parameter 'item' because I didn't know what is normal to call that kind of thing. Whatever name makes sense sounds good to me.

I updated find's signature but not the JSDocs.

I added this because I needed a way to search for a tab by function. This implementation is not necessarily the best way to do this (you're free to change it as you'd like), but this was just an easy way I thought of that would also keep backward compatibility.

Thanks for the hard work on rc-dock!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant