DynamicTablesPkg: Generates X64 MADT and CPU SSDT Topology Table #6443
+929
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdattar
force-pushed
the
CpuTopo
branch
2 times, most recently
from
60d29dc
to
879eeaf
Compare
|
Code looks pretty straightforward implementing building the local APIC data for x86_64 MADT tables. Looks pretty good to me. @abdattar The only thing I'd suggest is adding a bit more explanatory message in the commit messages. For example to briefly explain what the PR and each commit does, just to provide some context to the reviewers. @samimujawar @pierregondois any other thoughts? |
pierregondois
requested changes
Nov 20, 2024
DynamicTablesPkg/Library/Acpi/Common/AcpiSsdtCpuTopologyLib/X64/X64SsdtCpuTopologyGenerator.c
Outdated
Show resolved
Hide resolved
abdattar
changed the title
pierregondois
requested changes
Nov 21, 2024
|
Hi @pierregondois and @samimujawar, |
Sorry for the delay. I just have one minor comment. Otherwise LGTM |
abdattar
force-pushed
the
CpuTopo
branch
2 times, most recently
from
8b858aa
to
bf418f5
Compare
added 2 commits
November 28, 2024 12:08
Updates X64 namespace object. Updates the object parser. Updates the Readme. Cc: Sami Mujawar <[email protected]> Cc: Pierre Gondois <[email protected]> Signed-off-by: Abdul Lateef Attar <[email protected]>
Introduce support for generating ACPI CPU SSDT table for the X64 architecture. Creates processor objects based on configuration data. Cc: Sami Mujawar <[email protected]> Cc: Pierre Gondois <[email protected]> Signed-off-by: Abdul Lateef Attar <[email protected]>
samimujawar
approved these changes
Nov 28, 2024
pierregondois
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for generating ACPI CPU SSDT table for the X64 architecture.
Cc: Sami Mujawar [email protected]
Cc: Pierre Gondois [email protected]
Description
This PR contains two patches
Patch 1) Adds ACPI MADT generator library for X64 platform.
which handles various APIC structures within a system,
including Local APIC, IO APIC, Interrupt Source Override, and Local APIC NMI.
Patch 2) Implements the X64 support for existing ACPI CPU SSDT topology generator library.
Adds X64 related supporting functions.
Creates the ACPI cpu device object.
How This Was Tested
Tested on AMD platform.
Integration Instructions
N/A