DynamicTablesPkg/ArmGicCParser: Parse VGIC interrupt for all CPUs #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
leiflindholm,
pierregondois and
samimujawar
samimujawar
approved these changes
Nov 14, 2024
|
@mdkinney any clue what is wrong here? Sami approved this, and he is the maintainer of DynamicTablesPkg, and so I would expect the review requirement to be satisfied (No need for this to make the stable tag IMO, although it is a clear bugfix, so Sami might feel differently) |
ardbiesheuvel
force-pushed
the
kvmtool-madt-fix
branch
from
f846571
to
3ac8774
Compare
There are two issues in the GIC FDT parsing code: - the GICC Flags 'Enabled' bit is overwritten when parsing the VGIC Maintenance Interrupt, whose trigger type occupies another bit in the same field; - only the first CPU's Flags field is updated. This breaks both SMP boot and KVM support on Linux, given that the boot CPU is disabled in the MADT, and the VGIC maintenance interrupt is set to 0x0 on all others. Fix this, by OR'ing the trigger type into the field, and by iterating over all discovered CPUs. Signed-off-by: Ard Biesheuvel <[email protected]>
ardbiesheuvel
force-pushed
the
kvmtool-madt-fix
branch
from
3ac8774
to
63b4c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues in the GIC FDT parsing code:
This breaks both SMP boot and KVM support on Linux, given that the boot CPU is disabled in the MADT, and the VGIC maintenance interrupt is set to 0x0 on all others.
Fix this, by OR'ing the trigger type into the field, and by iterating over all discovered CPUs.