Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edk2-stable202411] MdeModulePkg/DxeIplPeim: Fix pagetable protection region in 5 leve paging #6430

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

NingFengGit
Copy link
Contributor

MedModulePkg/DxeIplPeim: Fix pagetable protection region in 5 leve paging

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4873

Currently the function does not cover the 5 level paging case. it will caused pagetable protection region to be set incorrectly. This patch do the enhancement and with the patch protection region has been set correctly.

CC: Ray Ni [email protected]

##Description
Currently the function does not cover the 5 level paging case. it will casued pagetable protection region set incorrectly. This patch do the enhancemant and with the patch protection region has been set correctly.

##How This Was Tested
we test on real platform with below condition:
5level pagetable +UPL, pagetable region been protected correctly.
4level pagetable+UPL, pagetable region been protected correctly.

5level pagetable +nonUPL pagetable region been protected correctly.
4level pagetable+nonUPL, pagetable region been protected correctly.

@tianocore-assign-reviewers
Copy link

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:


Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

…aging

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4873

Currently the function does not cover the 5 level paging case. it will
casued pagetable protection region set incorrectly. This patch do the
enhancemant and with the patch protection region has been set correctly.

Signed-off-by: Ning Feng <[email protected]>
Cc: Ray Ni <[email protected]>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4873

Currently the function does not cover the 5 level paging case. it will
casued pagetable protection region set incorrectly. This patch do the
enhancemant and with the patch protection region has been set correctly.

Signed-off-by: Ning Feng <[email protected]>
Cc: Ray Ni <[email protected]>
@niruiyu niruiyu added the push Auto push patch series in PR if all checks pass label Nov 14, 2024
@mdkinney
Copy link
Member

@niruiyu Is this for edk2-stable202411? Please update title if that is the request and add justification.

@niruiyu
Copy link
Member

niruiyu commented Nov 17, 2024

@niruiyu Is this for edk2-stable202411? Please update title if that is the request and add justification.

The patch fixes a critical bug when 5-level paging is enabled in the 64-bit PEI phase. The DxeIpl that runs at the end of PEI and the UplEntry that runs at the beginning of Payload both do not handle 5-l paging properly.

What title should be used for the stable-tag required changes? @NingFengGit can help to change accordingly.

@mdkinney
Copy link
Member

The title should start with [edk2-stable202411]. I will add that.

@mdkinney mdkinney changed the title MedModulePkg/DxeIplPeim: Fix pagetable protection region in 5 leve paging [edk2-stable202411] MdeModulePkg/DxeIplPeim: Fix pagetable protection region in 5 leve paging Nov 17, 2024
@mdkinney
Copy link
Member

Approved for edk2-stable202411

@mdkinney mdkinney self-requested a review November 17, 2024 20:17
@mergify mergify bot merged commit 0f3867f into tianocore:master Nov 17, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants