MdeModulePkg HobPrintLib: Add Guid to Guids section. #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niruiyu
approved these changes
Nov 6, 2024
lgao4
approved these changes
Nov 11, 2024
lgao4
force-pushed
the
personal/apop5/addguidtohobprint
branch
from
e897bc8
to
e34ced9
Compare
|
@lgao4 is this for edk2-stable202411? |
|
This is a bug fix for declaring the guids consumed by the library. If it is possible. Without it, the library cannot be consumed by any module, unless the module's INF declares gEfiHobMemoryAllocModuleGuid, or some other library the module consumes declares gEfiHobMemoryAllocModuleGuid. |
gEfiHobMemoryAllocModuleGuid is referenced in the HobPrintLib, but it is not defined in the INF file, causing an unresolved external error when the module is consumed by code. Signed-off-by: Aaron Pop <[email protected]>
lgao4
force-pushed
the
personal/apop5/addguidtohobprint
branch
from
e34ced9
to
18f8f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gEfiHobMemoryAllocModuleGuid is referenced in the HobPrintLib, but it is not defined in the INF file, causing an unresolved external error when the module is consumed by code.
How This Was Tested
Modified module to consume this library, experienced build error.
Corrected INF, module compiled correctly.
Integration Instructions
N/A