-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetworkPkg: Restore TPL Before Return #6298
Conversation
@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams friendly ping to review this small PR. |
@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams another friendly ping to review please |
@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams can someone review this small PR? |
@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams can you please review this small PR to get it in for the stable tag? |
@ajfish @leiflindholm @mdkinney @SaloniKasbekar @Zclarkwilliams there is no NetworkPkg maintainer, can you please review this small PR? The process is that the stewards need to review in the absence of a maintainer, right? |
There are reviewers and I asked them to review. Stewards can fill role of Maintainer after review is complete |
@mdkinney it's been 6 weeks and the reviewers are not reviewing :) |
If this is considered a critical bug fix for edk2-stable202411, then please prefix title with |
I don't think this needs to be included in the stable tag. It just had been sitting for 6 weeks so I was trying to get traction on the simple bugfixes here. They are bugfixes, but only ones seen through code inspection, so no urgency to get into the stable tag. |
@mdkinney I have scoped this PR to only the restore TPL fixes and @Zclarkwilliams has reviewed. Please re-review when you have a chance. As I mentioned, I don't think this needs to hit the stable tag, but certainly can if desired. |
This patch fixes a few instances of error cases in NetworkPkg returning after a RaiseTPL call without restoring the TPL first. Signed-off-by: Oliver Smith-Denny <[email protected]>
Description
This patch fixes a few instances of error cases in NetworkPkg returning after a RaiseTpl call without restoring the TPL first.
How This Was Tested
Code review.
Integration Instructions
N/A.