BaseTools: Add /DRIVER to CLANGPDB link flags #10638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This quiets the warning reported in Issue tianocore#10637. Signed-off-by: Dionna Glaze <[email protected]>
tianocore-assign-reviewers
bot
requested review from
bexcran,
BobCF,
lgao4 and
YuweiChen1110
|
I don't think we want this at this scope because it can not be overriden. When building apps like GoogleTest we do not want /DRIVER. |
|
Why is /DRIVER in all the VS build type DLINK_FLAGS then? |
|
I believe it is required for the UEFI module types. I am not sure if that has changes with newer compilers/linkers or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This quiets the warning reported in Issue #10637. /ALIGN is not expected to be overridden without /DRIVER, which is correctly passed in the MSVC linker flags.
How This Was Tested
Built before and after to see the warning disappear.
Integration Instructions
N/A