Move measurevariable #470
Merged
Move measurevariable #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
move_measurevariable
branch
2 times, most recently
from
670ccfb to
7ce7bad
Compare
jyao1
reviewed
Jan 31, 2024
| @@ -2333,6 +2334,36 @@ MeasureAllSecureVariables ( | |||
| DEBUG ((DEBUG_INFO, "Skip measuring variable %s since it's deleted\n", EFI_IMAGE_SECURITY_DATABASE2)); | |||
| } | |||
|
|
|||
| // | |||
| // Meaurement UEFI device signature database | |||
There was a problem hiding this comment.
Thanks. I have added the measure.
Wenxing-hou
force-pushed
the
move_measurevariable
branch
from
7ce7bad to
54998b9
Compare
jyao1
reviewed
Feb 2, 2024
MdePkg/MdePkg.dec
Outdated
| # | ||
| ## GUID used to specify section with devdb content | ||
| ## Include/Guid/DeviceAuthentication.h | ||
| gEdkiiDeviceSignatureDatabaseGuid = {0xb9c2b4f4, 0xbf5f, 0x462d, {0x8a, 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d, 0xad}} |
There was a problem hiding this comment.
I have fixed the name.
jyao1
reviewed
Feb 2, 2024
Wenxing-hou
force-pushed
the
move_measurevariable
branch
from
54998b9 to
791821b
Compare
Zhiqiang520
reviewed
Feb 2, 2024
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
Outdated
| Status = MeasureVariable ( | ||
| PCR_INDEX_FOR_SIGNATURE_DB, | ||
| EV_EFI_SPDM_DEVICE_POLICY, | ||
| EDKII_DEVICE_SECURITY_DATABASE, |
There was a problem hiding this comment.
I think here EDKII_DEVICE_SECURITY_DATABASE should be changed to EFI_DEVICE_SECURITY_DATABASE.
There was a problem hiding this comment.
Thanks. I have fixed the name error.
Zhiqiang520
reviewed
Feb 2, 2024
Wenxing-hou
force-pushed
the
move_measurevariable
branch
from
791821b to
424755d
Compare
Wenxing-hou
force-pushed
the
move_measurevariable
branch
from
424755d to
932d736
Compare
…measure Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Change gEdkiiDeviceSignatureDatabaseGuid and EDKII_DEVICE_SECURITY_DATABASE prefix Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
move_measurevariable
branch
from
932d736 to
642b52f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.