path_utilities: Use pathlib #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
force-pushed
the
path_utilities
branch
from
48d9bfe
to
c171d7c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 78.68% 78.68% -0.01%
==========================================
Files 47 47
Lines 6729 6728 -1
==========================================
- Hits 5295 5294 -1
Misses 1434 1434
☔ View full report in Codecov by Sentry. |
Javagedes
force-pushed
the
path_utilities
branch
from
190af7b
to
f4d81cf
Compare
Javagedes
requested review from
makubacki and
spbrogan
and removed request for
makubacki
makubacki
approved these changes
Aug 2, 2023
Javagedes
force-pushed
the
path_utilities
branch
3 times, most recently
from
9c4a916
to
df48c67
Compare
Updates path_utilities to use pathlib rather than os.path functionality as it abstracts away posix vs windows path separators. Continues to provides self.WorkspacePath and self.PackagePath as a string and list of strings respectively, but internally they are held as a pathlib.Path object and internal functionality uses it as such. Resolves an issue where GetEdk2RelativePathFromAbsolutePath could return a Non-Posix path.
Javagedes
force-pushed
the
path_utilities
branch
from
df48c67
to
a364375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates path_utilities to use pathlib rather than os.path functionality as it abstracts away posix vs windows path separators.
Continues to provides self.WorkspacePath and self.PackagePath as a string and list of strings respectively, but internally they are held as a pathlib.Path object and internal functionality uses it as such.
Resolves an issue where GetEdk2RelativePathFromAbsolutePath could return a Non-Posix path.
closes #207
Also making initial updates in preparation for deprecating mws (multiple_workspace.py in edk2-pytool-extensions) found in tianocore/edk2-pytool-extensions#446