Update ARM/AARCH64 Platforms to Use New ArmMmuLib Instances #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
requested review from
ardbiesheuvel,
leiflindholm,
hrw,
ndhillonm,
wojtas-marcin,
samimujawar,
nhivp,
bexcran,
chuongtranle,
abdattar,
changab and
pbgrimes
as code owners
3 tasks
|
The changes for Mt. Jade cause a crash. I'm unsure if you have any idea while I need to get more time to dig into it |
|
edk2 at: edk2-platforms at: System (QemuSbsa) crashed: I try to run code before review. |
|
@os-d you may find this post useful: https://marcin.juszkiewicz.com.pl/2024/03/25/running-sbsa-reference-platform/ |
|
@hrw , using your blog + the build steps here, neither my edk2 PR + edk2-platforms PR nor master + master boots sbsa-qemu for me: Something else I need to do? This is using the top of tree precompiled TF-A bins in edk2-non-osi. |
|
@os-d what you got is due to use of old edk2-non-osi binaries as tianocore/edk2-non-osi@17c42d6 was pushed to add that SIP_SVC_GET_CPU_TOPOLOGY call. |
|
Tested on Arm Juno. No issues encountered on my end. |
@hrw , I did a fresh clone of edk2-non-osi for this and it is at 889f9c90de53e7c8729d1f449b8781a5477f0df4, from Oct 17, and I see the commit you are referencing in I also tried building a fresh clone of TF-A (commit dddded141458fe1ff8fcbf8f3080dbf20953e7a4 from Nov 1) and added a custom print to make sure that my TF-A was getting loaded and it is: NOTICE: Booting os-d Firmware But I still get the same error. I'm still probably doing something wrong, but I don't know what it is :) |
os-d
force-pushed
the
armmmulib_update
branch
from
e5978b0
to
3311256
Compare
|
@hrw , I was able to repro the issue by commenting out the call to TF-A to get the cpu topology. I fixed the issue, I was linking ArmMmuPeiLib into your platform (and most of the others) when previously they were using ArmMmuBaseLib. I fixed the linkage. Can you and @nhivp please confirm this fixes your issue? QemuSbsa boots to shell for me now. |
edk2 PR tianocore/edk2#6286 is updating ArmMmuLib instances to a SEC, PEI, and BASE version to support pre-allocating page table memory. This commit makes the necessary changes in edk2-platforms to resolve the breaking change. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny <[email protected]>
os-d
force-pushed
the
armmmulib_update
branch
from
3311256
to
2fe20eb
Compare
nhivp
approved these changes
Nov 9, 2024
samimujawar
approved these changes
Nov 11, 2024
leiflindholm
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edk2 PR tianocore/edk2#6286 is updating ArmMmuLib instances to a SEC, PEI, and BASE version to support pre-allocating page table memory.
This commit makes the necessary changes in edk2-platforms to resolve the breaking change. This needs to be checked in after the edk2 PR is checked in.
Continuous-integration-options: PatchCheck.ignore-multi-package