Minor UI improvements #2305
Minor UI improvements #2305
Conversation
...by using icons instead of text, leaving more space and proper padding.
Co-Authored-By: changhuapeng <[email protected]>
in Home.kt the install function is called everytime you go to the HomeScreen, move it to MainActivity instead so it's executed on app launch only. Co-Authored-By: Rifat Azad <[email protected]>
|
heres how it looks for me Tested-by: backslashxx [email protected] |
|
I don’t think only shows the icon will looks nice |
Well I can edit it to display text if there's only another one button but question is, how many times do you actually need to do it? Missclicking isn't punishing anymore partly for this reason. Also displaying both text and icon when update and uninstall are present would feels disproportionate on the left side (maybe make it display text only with action or webui, but not with update?). Spacing cannot be improved much, depending on DPI you could have even less free space with the actual one - here's an example
|
Changes
With the addition of the Action button the module card feels pretty bloated when all of them are present at the same time.
To improve it we can use icons only instead of text since they take less space; this also means adding an icon for Update and Uninstall buttons.
Below are displayed other possible behaviors when not all of them are present:
Since the Update button appears less frequently than the others, make it always display its text unless both Action and WebUI are present.
Minor change to avoid possible missclicks caused by smaller buttons. Enabling and disabling modules is pretty rare by itself and considering overlayfs isn't as fast as magic mount a missclick often feels pretty punishing.
The commit 7b3e732 readded transitions to all sections but I noticed they were missing from Home. With the help of @rifsxd I found out it was cause of the lag generated by the install function, which is called everytime you go to Home. Since installing magiskboot multiple times isn't needed, moving it to MainActivity ensures it's executed on app launch only avoiding unnecessary lag.
Tested-by: backslashxx [email protected]