Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot, Update Dependencies and Workflows #1440

Merged
merged 25 commits into from
Mar 20, 2024
Merged

Add Dependabot, Update Dependencies and Workflows #1440

merged 25 commits into from
Mar 20, 2024

Conversation

CanerKaraca23
Copy link
Contributor

Build may fail because of some major dependency updates. Needs changes, changes/fixes welcomed.

Main goal is keeping all things up-to-date.

@tiann
Copy link
Owner

tiann commented Mar 16, 2024

I'll make it work in next release, please wait a moment, thank you.

@tiann
Copy link
Owner

tiann commented Mar 18, 2024

cross build --target aarch64-linux-android --release --manifest-path ./userspace/ksud/Cargo.toml
Warning: using older rustc `1.67.0 (fc594f156 2023-01-24)` for the target. Current active rustc on the host is `rustc 1.75.0 (82e1608df 2023-12-21)`.
 > Update with `rustup update --force-non-host stable-x86_64-unknown-linux-gnu`
error: package `clap v4.5.3` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `clap` supporting rustc 1.67.0
error: Recipe `build_ksud` failed on line 5 with exit code 101

cross-rs/cross#1222

@CanerKaraca23
Copy link
Contributor Author

cross build --target aarch64-linux-android --release --manifest-path ./userspace/ksud/Cargo.toml
Warning: using older rustc `1.67.0 (fc594f156 2023-01-24)` for the target. Current active rustc on the host is `rustc 1.75.0 (82e1608df 2023-12-21)`.
 > Update with `rustup update --force-non-host stable-x86_64-unknown-linux-gnu`
error: package `clap v4.5.3` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `clap` supporting rustc 1.67.0
error: Recipe `build_ksud` failed on line 5 with exit code 101

cross-rs/cross#1222

So, downgrade rust version to 1.67?

@CanerKaraca23
Copy link
Contributor Author

Should we update Linux versions of Build Kernel - ChromeOS ARCVM and Build Kernel - WSA workflows from 20.04 to 22.04? Will it break anything? Didn't wanted to do without asking you.

@tiann
Copy link
Owner

tiann commented Mar 19, 2024

Should we update Linux versions of Build Kernel - ChromeOS ARCVM and Build Kernel - WSA workflows from 20.04 to 22.04? Will it break anything? Didn't wanted to do without asking you.

I think it won't break

@tiann tiann merged commit 8f33926 into tiann:main Mar 20, 2024
38 checks passed
@CanerKaraca23
Copy link
Contributor Author

Should we update Linux versions of Build Kernel - ChromeOS ARCVM and Build Kernel - WSA workflows from 20.04 to 22.04? Will it break anything? Didn't wanted to do without asking you.

I think it won't break

Ah, merged, should i create a new pr for it or you will update it?

@tiann
Copy link
Owner

tiann commented Mar 20, 2024

Should we update Linux versions of Build Kernel - ChromeOS ARCVM and Build Kernel - WSA workflows from 20.04 to 22.04? Will it break anything? Didn't wanted to do without asking you.

I think it won't break

Ah, merged, should i create a new pr for it or you will update it?

You can make a new pr

@tiann
Copy link
Owner

tiann commented Mar 20, 2024

The apk signature seems broken after this PR

@CanerKaraca23
Copy link
Contributor Author

The apk signature seems broken after this PR

Updated from 1.1 to 1.4

https://github.com/LSPosed/LSPlugin/packages/1795939

@CanerKaraca23
Copy link
Contributor Author

The apk signature seems broken after this PR

Maybe try version 1.3 or 1.2 instead of reverting back to 1.1 @tiann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants