Skip to content

Commit

Permalink
Docs: add backport notice in module umount docs (#1476)
Browse files Browse the repository at this point in the history
This aims to uniform the documentation since the official introduction
of pre-GKI modules umount feature
  • Loading branch information
Fede2782 authored Mar 19, 2024
1 parent 97faab6 commit 1fc1ffe
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion kernel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ ifeq ($(shell grep -q "int path_umount" $(srctree)/fs/namespace.c; echo $$?),0)
ccflags-y += -DKSU_UMOUNT
else
$(info -- Did you know you can backport path_umount to fs/namespace.c from 5.9?)
$(info -- Read: https://kernelsu.org/guide/how-to-integrate-for-non-gki.html#path_umount)
$(info -- Read: https://kernelsu.org/guide/how-to-integrate-for-non-gki.html#how-to-backport-path_umount)
endif

ccflags-y += -Wno-implicit-function-declaration -Wno-strict-prototypes -Wno-int-conversion -Wno-gcc-compat
Expand Down
2 changes: 1 addition & 1 deletion website/docs/guide/app-profile.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,5 +114,5 @@ Additionally, the settings interface of the KernelSU manager provides a switch f
2. Disable the switch for "umount modules by default" and individually enable the "umount modules" option in the App Profile for apps requiring module unloading (acting as a "blacklist").

:::info
In devices using kernel version 5.10 and above, the kernel performs the unloading of modules. However, for devices running kernel versions below 5.10, this switch is merely a configuration option, and KernelSU itself does not take any action. Some modules, such as Zygisksu, may use this switch to determine whether module unloading is necessary.
In devices using kernel version 5.10 and above, the kernel performs without any further action the unloading of modules. However, for devices running kernel versions below 5.10, this switch is merely a configuration option, and KernelSU itself does not take any action. If you want to be able to use the "umount modules" option in kernel versions before 5.10 you need to backport the ```path_umount``` function in ```fs/namespace.c```, you can get more information at the end of the [How to integrate for non GKI](https://kernelsu.org/guide/how-to-integrate-for-non-gki.html#how-to-backport-path_umount) page. Some modules, such as Zygisksu, may also use this switch to determine whether module unloading is necessary.
:::
2 changes: 1 addition & 1 deletion website/docs/guide/how-to-integrate-for-non-gki.md
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ index 45306f9ef247..815091ebfca4 100755
add_input_randomness(type, code, value);
```

## path_umount
### How to backport path_umount

You can get module umount feature working on pre-GKI kernels by manually backporting ```path_umount``` from 5.9. You can use this patch as reference:

Expand Down

0 comments on commit 1fc1ffe

Please sign in to comment.