fix(internal/pkg/externalplugins/cherrypicker): do not change commit message #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
dco-signoff: yes
ti-chi-bot
bot
added
the
size/L
wuhuizuo
commented
Aug 6, 2024
| @@ -646,7 +646,7 @@ func (s *Server) handle(logger *logrus.Entry, requestor string, | |||
| } | |||
|
|
|||
| // Try git cherry-pick. | |||
| cherrypick := ex.Command("git", "cherry-pick", "-m", "1", *pr.MergeSHA) | |||
| cherrypick := ex.Command("git", "cherry-pick", "-m", "1", "--cleanup=verbatim", *pr.MergeSHA) | |||
There was a problem hiding this comment.
just this line will fix the line join issue.
…message add option for `git cherry-pick command`: `--cleanup=verbatim`. Signed-off-by: wuhuizuo <[email protected]>
wuhuizuo
force-pushed
the
fix/cherry-picker-commit-message
branch
from
bf42654
to
de79f85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
- Coverage 80.48% 80.47% -0.02%
==========================================
Files 21 21
Lines 3326 3324 -2
==========================================
- Hits 2677 2675 -2
Misses 419 419
Partials 230 230 ☔ View full report in Codecov by Sentry. |
Signed-off-by: wuhuizuo <[email protected]>
ti-chi-bot
bot
added
size/XL
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
|
/retest |
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option for
git cherry-pick command:--cleanup=verbatim.Signed-off-by: wuhuizuo [email protected]
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works: