-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move environment config into connection task #153
base: master
Are you sure you want to change the base?
Conversation
would love to get some feedback on this proposed change. Maybe even suggestions how to get it working with older version of activerecord. |
Agreed, it's not ideal that the config is required even when the task isn't called. If anyone else using the project also has this need feel free to offer @salzig a hand or offer suggestions to try and come up with a general purpose approach for this. |
Hello @thuss @salzig . Can you merged the Pull Request ( @thuss )? I need the feature that fixes this issue. I need the feature because I use Multiple database support and when I type a command
|
With this change the unit tests on Travis are failing with ActiveRecord 4.2.0 and 5.0.0 which is why this PR has never been merged. I think it's fine to say we don't support those older versions anymore but that will require changes in Gemfile, standalone_migrations.gemspec, and .travis.yml before we could merge this PR. |
just ran into the same issue! |
also why is the file path hardcoded? shouldnt it be configurable? |
move environment configuration into connection task, so it's not executed in situations where no standalone-migrations task is called. Allows other rake tasks to be executed when db/config.yml is missing.
fixes #152