Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ckeditor migration #761

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Dynamic ckeditor migration #761

merged 2 commits into from
Dec 19, 2023

Conversation

chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@chrfritsch chrfritsch added the test-upgrade Triggers the upgrade path testing label Dec 19, 2023
@ol0lll ol0lll temporarily deployed to thunder-pr-761 December 19, 2023 09:04 Inactive
@chrfritsch chrfritsch merged commit bc4cbe0 into 7.1.x Dec 19, 2023
11 checks passed
@chrfritsch chrfritsch deleted the dynamic-editor-migration branch December 19, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-upgrade Triggers the upgrade path testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants