Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3401211 by daniel.bosen, IT-Cru: Possible break of Thunder GraphQL schema with drupal/graphql:4.6.0 #756

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented Nov 13, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@dbosen dbosen changed the title Thndr 1575 Issue #3401211 by daniel.bosen, IT-Cru: Possible break of Thunder GraphQL schema with drupal/graphql:4.6.0 Nov 13, 2023
@ol0lll ol0lll temporarily deployed to thunder-pr-756 November 13, 2023 12:51 Inactive
@dbosen dbosen merged commit 86c108e into 7.1.x Nov 28, 2023
11 checks passed
@dbosen dbosen deleted the THNDR-1575 branch November 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants