Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3396526 by shagel, volkerk: Labels of input fields are missing #752

Open
wants to merge 14 commits into
base: 7.3.x
Choose a base branch
from

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Oct 27, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-752 October 27, 2023 12:31 Inactive
@dbosen dbosen requested a review from shagel7984 October 30, 2023 08:02
@shagel7984
Copy link
Contributor

.field--name-field-paragraphs .paragraphs-tabs-wrapper [data-drupal-selector="edit-field-paragraphs"] > table.field-multiple-table > thead {
display: none;
}

the .field--name-field-paragraphs
and .paragraphs-tabs-wrapper [data-drupal-selector="edit-field-paragraphs"] seems to specific.

for example we have a field--name-field-top-paragraphs in another field.
i guess it would be better to take field--type-entity-reference-revisions or field--widget-paragraphs

also in our case the data-drupal-selector does not match since its:

@ol0lll ol0lll changed the base branch from 7.1.x to 7.2.x April 30, 2024 10:32
shagel7984
shagel7984 previously approved these changes Jun 24, 2024
@ol0lll ol0lll changed the base branch from 7.2.x to 7.3.x July 11, 2024 06:50
@ol0lll ol0lll dismissed shagel7984’s stale review July 11, 2024 06:50

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants