Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonld and slick tests. #749

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Fix jsonld and slick tests. #749

merged 7 commits into from
Oct 24, 2023

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented Oct 24, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 08:32 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 08:34 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 10:16 Inactive
@dbosen dbosen added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels Oct 24, 2023
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 10:54 Inactive
@dbosen dbosen changed the title improve jsonld test Fix jsonld and fix slick tests. Oct 24, 2023
@dbosen dbosen changed the title Fix jsonld and fix slick tests. Fix jsonld and slick tests. Oct 24, 2023
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 11:24 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 11:27 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-749 October 24, 2023 12:47 Inactive
@dbosen dbosen merged commit 8fa33cb into 7.1.x Oct 24, 2023
11 checks passed
@dbosen dbosen deleted the fix-json-test branch October 24, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants