Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focal point patch #748

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Update focal point patch #748

merged 2 commits into from
Oct 24, 2023

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented Oct 23, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-748 October 23, 2023 16:09 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-748 October 24, 2023 13:33 Inactive
@dbosen dbosen merged commit e29e9c9 into 7.1.x Oct 24, 2023
6 checks passed
@dbosen dbosen deleted the update-patch branch October 24, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants