Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Thunder's menu GQLS for better accessibility and SEO #702

Open
wants to merge 27 commits into
base: 7.3.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
263e05f
News article
dbosen Mar 27, 2023
10c1236
Add reference field to ParagraphVideo type
chrfritsch Mar 30, 2023
77f21f8
Allow multiple media types in entity browser view
chrfritsch Mar 30, 2023
8b73dbf
Add xymatic integration
chrfritsch Mar 30, 2023
a937d00
Release 6.5.4
chrfritsch Mar 30, 2023
778cccf
feat: improve Thunder's menu GQLS for better accessibility and SEO
IT-Cru Apr 18, 2023
1b7d8a9
Add configurable quick links to ThunderParagraphsTestTrait
IT-Cru Apr 19, 2023
d024ad4
feat(thunder_xymatic): add default and paragraph_preview entity view …
chrfritsch Apr 26, 2023
411fe0d
Merge branch '6.5.x' into feature/improve-thunder-menu-gqls
dbosen Apr 27, 2023
e3e6302
Fix code style issues
dbosen May 4, 2023
862e85b
Disable gpu and shared memory for webdriver
chrfritsch May 16, 2023
f62a615
Add description to xymatic
chrfritsch May 16, 2023
4a0a560
Add video and xymatic type
chrfritsch May 16, 2023
4031ad6
fix: tests are indicating a success, but never ran
chrfritsch May 17, 2023
8ec2be6
Issue #3361796: Release Thunder 6.5.5
dbosen May 25, 2023
37b013b
Use drupalci chromedriver for testing.
ol0lll May 30, 2023
c9a99db
Fix tests
dbosen Jun 7, 2023
ba11d73
Fix order of use statements.
dbosen Jun 12, 2023
80102d9
Add decorated type resolver
dbosen Jun 14, 2023
931be43
Issue #3366947 by chr.fritsch: Release Thunder 6.5.6
dbosen Jun 15, 2023
0f80c3b
Composer project version 3.x
dbosen Jun 22, 2023
20f8120
Release 6.5.7
ol0lll Aug 3, 2023
615608f
Merge branch '6.5.x' into feature/improve-thunder-menu-gqls
dbosen Apr 29, 2024
92157e2
Merge remote-tracking branch 'origin/7.2.x' into feature/improve-thun…
dbosen Apr 29, 2024
7a214b8
cleanup
dbosen Apr 29, 2024
31af1f2
Merge branch '7.2.x' into feature/improve-thunder-menu-gqls
dbosen Aug 21, 2024
9ac317e
Merge remote-tracking branch 'origin/7.3.x' into feature/improve-thun…
dbosen Sep 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/thunder_gqls/graphql/thunder_menu.base.graphqls
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ type Menu {

type MenuItem {
title: String!
description: String
url: String!
expanded: Boolean!
inActiveTrail: Boolean!
children: [MenuItem]
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function registerResolvers(ResolverRegistryInterface $registry): void {

);

// Menu title.
// Menu item title.
$this->addFieldResolverIfNotExists(
'MenuItem',
'title',
Expand All @@ -64,23 +64,47 @@ public function registerResolvers(ResolverRegistryInterface $registry): void {
)
);

// Menu in active trail.
// Menu item description.
$this->addFieldResolverIfNotExists(
'MenuItem',
'description',
$this->builder->produce('menu_link_description')
->map(
'link',
$this->builder->produce('menu_tree_link')
->map('element', $this->builder->fromParent())
)
);

// Menu item expanded.
$this->addFieldResolverIfNotExists(
'MenuItem',
'expanded',
$this->builder->produce('menu_link_expanded')
->map(
'link',
$this->builder->produce('menu_tree_link')
->map('element', $this->builder->fromParent())
)
);

// Menu item in active trail.
$this->addFieldResolverIfNotExists(
'MenuItem',
'inActiveTrail',
$this->builder->produce('menu_tree_in_active_trail')
->map('element', $this->builder->fromParent())
);

// Menu children.
// Menu item children.
$this->addFieldResolverIfNotExists(
'MenuItem',
'children',
$this->builder->produce('menu_tree_subtree')
->map('element', $this->builder->fromParent())
);

// Menu url.
// Menu item url.
$this->addFieldResolverIfNotExists(
'MenuItem',
'url',
Expand Down
Loading