Skip to content

Commit

Permalink
Some fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian Fritsch committed Jan 8, 2025
1 parent 790dc41 commit 949cecd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ env:
DRUPAL_TESTING_SELENIUM_PORT: 9515
PHPSTAN_MEMORY_LIMIT: 4G
DRUPAL_TESTING_PARALLEL_TESTING: false
MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", {"browserName":"chrome","chromeOptions":{"args":["--disable-gpu","--headless", "--no-sandbox", "--disable-dev-shm-usage"]}}, "http://127.0.0.1:9515"]'
MINK_DRIVER_ARGS_WEBDRIVER: '["chrome", {"browserName":"chrome","goog:chromeOptions":{"args":["--disable-gpu","--headless", "--no-sandbox", "--disable-dev-shm-usage"]}}, "http://127.0.0.1:9515"]'
SIMPLETEST_BASE_URL: http://thunder-testing:8888
BROWSERTEST_OUTPUT_DIRECTORY: /tmp
SKIP_TEST_CLEANUP: true
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
run: test-drupal-project prepare_build

- name: Add necessary packages to lenient
run: composer config --json extra.drupal-lenient.allowed-list '["drupal/autosave_form", "drupal/vgwort", "drupal/media_entity_slideshow", "drupal/media_entity_twitter", "drupal/metatag_async_widget", "drupal/media_library_media_modify", "drupal/paragraphs_features", "drupal/select2", "drupal/paragraphs_paste", "drupal/ivw_integration", "thunder/thunder_testing_demo"]'
run: composer config --json extra.drupal-lenient.allowed-list '["drupal/select2", "thunder/thunder_testing_demo"]'
working-directory: /tmp/test/thunder/install

- name: Build the docroot
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"drupal/search_api": "^1.29",
"drupal/views_bulk_edit": "^3.0",
"drupal/views_bulk_operations": "^4.2.7",
"drupal/vgwort": "^2.0@beta",
"drupal/vgwort": "^3.0@beta",
"drupal/xymatic": "^1.0@beta",
"npm-asset/dropzone": "^5.5.1",
"npm-asset/exif-js": "^2.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Drupal\Core\Breadcrumb\Breadcrumb;
use Drupal\Core\Breadcrumb\BreadcrumbBuilderInterface;
use Drupal\Core\Cache\CacheableMetadata;
use Drupal\Core\Config\ConfigFactoryInterface;
use Drupal\Core\Entity\EntityRepositoryInterface;
use Drupal\Core\Entity\EntityTypeManagerInterface;
Expand Down Expand Up @@ -45,7 +46,7 @@ public function __construct(EntityTypeManagerInterface $entityTypeManager, prote
/**
* {@inheritdoc}
*/
public function applies(RouteMatchInterface $route_match): bool {
public function applies(RouteMatchInterface $route_match, ?CacheableMetadata $cacheable_metadata = NULL): bool {
// This breadcrumb apply only for all articles.
$parameters = $route_match->getParameters()->all();
if (($route_match->getRouteName() === 'entity.node.canonical') && is_object($parameters['node'])) {
Expand Down

0 comments on commit 949cecd

Please sign in to comment.