Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected SQL generation logic to prevent parsing errors #459

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Corrected SQL generation logic to prevent parsing errors #459

merged 2 commits into from
Nov 13, 2024

Conversation

YangYumings
Copy link
Contributor

@YangYumings YangYumings commented Nov 13, 2024 •
edited
Loading

Cause:

deviceSchema.getDevicePath() returns group.device, which lacks the “root.test” prefix.

OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 24c4157 into thulab:master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YangYumings @OneSizeFitsQuorum